Skip to content

Feature/historical conditions #8148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Feature/historical conditions #8148

wants to merge 43 commits into from
+858 −61

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Aug 26, 2025 •
edited
Loading

Closes #8082
Closes #8083

Describe your changes:

Adds the ability to evaluate conditions historically.

Majority of the work completed by @khalidadil

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

jvigliotta and others added 30 commits September 12, 2024 09:28
@jvigliotta
adding telemetry collections to condition manager
b4fdabf
@jvigliotta
handling telemetry collection data not datum
5bd5ca9
@jvigliotta
adding from maaster
4ab19e3
@jvigliotta
addressing PR comments
b467f9c
@jvigliotta
Merge branch 'master' into conditional-style-performance
3f66140
@jvigliotta
update unit test to work with telemetry collections
6482135
@jvigliotta
fixing tests
54c90e0
@jvigliotta
removing unnecessary addition
94a4ff3
@jvigliotta
removing focused describe
7cba09b
@jvigliotta
removing focused it
405b497
@jvigliotta
Merge branch 'master' into conditional-style-performance
1581216
@jvigliotta
fix weird test bleed
5b385ea
@jvigliotta
Merge branch 'conditional-style-performance' of https://github.com/na…
73489cd 
…sa/openmct into conditional-style-performance

mergin master
@khalidadil
Add realtime output of telemetry data in conditionals and add support…
23cf829 
… for historical conditional telemetry queries to allow for plotting
@khalidadil
Cleanup and add missing files
21e94fd
@khalidadil
Fix issue with missing data
101baa5
@khalidadil
Update emitted values
7896f36
@khalidadil
Addressing feedback
4b39ea2
@khalidadil
Creating a const for telemetry value
b975554
@khalidadil
Cleanup
7727a90
@khalidadil
Pass through plot options
f544a1d
@khalidadil
Cleanup
1180597
@khalidadil
Fix problem introduced with const
39a73cf
@khalidadil
Add back initialize on mount
0f2f71f
@khalidadil
Compensate for missing data at certain timestamps
4a3b0b9
@khalidadil
Rename file
a739d61
@khalidadil
Rename file
488178a
@khalidadil
Update metadata provider
f239d4b
@khalidadil
Update condition set metadata
f4c2b79
@khalidadil
Fix zero issue
bd3f00c
@jvigliotta
Copy link
Contributor Author

supersedes #7868

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 26, 2025
View reviewed changes
src/plugins/condition/historicalTelemetryWorker.js
return historicalTelemetryDateMap;
}

self.onmessage = function (e) {

Check warning

Code scanning / CodeQL

Missing origin verification in `postMessage` handler Medium

Postmessage handler has no origin check.

Copilot Autofix

AI 9 days ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

@jvigliotta jvigliotta added the type:feature Feature. Required intentional design label Aug 26, 2025
@jvigliotta jvigliotta added this to the 4.1.1 milestone Aug 26, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 2.80374% with 208 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.35%. Comparing base (896d77a) to head (1c8cae3).

Files with missing lines Patch % Lines
...c/plugins/condition/HistoricalTelemetryProvider.js 0.00% 129 Missing ⚠️
src/plugins/condition/ConditionManager.js 0.00% 56 Missing ⚠️
...lugins/condition/ConditionInspectorViewProvider.js 18.18% 9 Missing ⚠️
.../plugins/condition/ConditionSetMetadataProvider.js 0.00% 7 Missing ⚠️
...gins/plot/stackedPlot/mixins/objectStyles-mixin.js 0.00% 5 Missing ⚠️
...plugins/condition/ConditionSetTelemetryProvider.js 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (896d77a) and HEAD (1c8cae3). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (896d77a) HEAD (1c8cae3)
unit 3 0
e2e-ci 8 3
e2e-full 4 1
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8148      +/-   ##
==========================================
- Coverage   57.17%   50.35%   -6.82%     
==========================================
  Files         704      459     -245     
  Lines       28283    14281   -14002     
  Branches     2770        0    -2770     
==========================================
- Hits        16170     7191    -8979     
+ Misses      11767     7090    -4677     
+ Partials      346        0     -346
Flag Coverage Δ
e2e-ci 50.25% <2.80%> (-12.91%) ⬇️
e2e-full 23.38% <1.86%> (-18.99%) ⬇️
unit ?
Files with missing lines Coverage Δ
src/plugins/condition/plugin.js 72.72% <100.00%> (-27.28%) ⬇️
src/plugins/condition/utils/constants.js 100.00% <100.00%> (ø)
src/plugins/plot/tickUtils.js 74.64% <100.00%> (-22.54%) ⬇️
...plugins/condition/ConditionSetTelemetryProvider.js 14.28% <0.00%> (-80.72%) ⬇️
...gins/plot/stackedPlot/mixins/objectStyles-mixin.js 35.41% <0.00%> (-49.69%) ⬇️
.../plugins/condition/ConditionSetMetadataProvider.js 16.66% <0.00%> (-83.34%) ⬇️
...lugins/condition/ConditionInspectorViewProvider.js 18.18% <18.18%> (ø)
src/plugins/condition/ConditionManager.js 0.00% <0.00%> (-87.57%) ⬇️
...c/plugins/condition/HistoricalTelemetryProvider.js 0.00% <0.00%> (ø)

... and 443 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896d77a...1c8cae3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jvigliotta jvigliotta requested a review from akhenry August 27, 2025 20:42
@jvigliotta jvigliotta marked this pull request as ready for review August 27, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhenry akhenry Awaiting requested review from akhenry

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

type:feature Feature. Required intentional design

Projects

None yet

Milestone

4.1.1

Development

Successfully merging this pull request may close these issues.

Support a mode where Condition Sets emit the underlying telemetry value when true Support conditional evaluation of historical telemetry

2 participants

@jvigliotta @khalidadil